Skip to content

feat(insights): update Recently Added card to Featured #2445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 6, 2025

Conversation

devin-ai-integration[bot]
Copy link
Contributor

Update "Recently Added" card to "Featured"

This PR updates the "Recently Added" card and table title to "Featured" in the insights hub price feeds page. It also changes the icon to a star icon from the @phosphor-icons/react package.

Additionally, it renames the featuredRecentlyAdded field to featuredFeeds in the static config and updates the contents of that field with the specified list of price feeds.

Changes

  • Changed the title from "Recently Added" to "Featured"
  • Changed the icon from StackPlus to Star
  • Renamed the featuredRecentlyAdded field to featuredFeeds in the static config
  • Updated the contents of the featuredFeeds field with the provided list

Link to Devin run: https://app.devin.ai/sessions/f910bfd00da54f2880425242900d27c8
Requested by: Connor

Co-Authored-By: Connor Prussin <connor@dourolabs.xyz>
@devin-ai-integration devin-ai-integration bot requested a review from a team as a code owner March 6, 2025 04:22
Copy link
Contributor Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add "(aside)" to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

Copy link

vercel bot commented Mar 6, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
api-reference ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 6, 2025 5:10am
insights ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 6, 2025 5:10am
proposals ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 6, 2025 5:10am
staking ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 6, 2025 5:10am
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
component-library ⬜️ Ignored (Inspect) Visit Preview Mar 6, 2025 5:10am
entropy-debugger ⬜️ Ignored (Inspect) Visit Preview Mar 6, 2025 5:10am

title="Recently Added"
icon={<StackPlus />}
title="Featured"
icon={<Star />}
feeds={featuredRecentlyAdded}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update this variable to be named featuredFeeds instead

Co-Authored-By: Connor Prussin <connor@dourolabs.xyz>
@@ -129,29 +129,29 @@ export const PriceFeeds = async () => {
};

type FeaturedFeedsProps = {
featuredRecentlyAdded: FeaturedFeed[];
featuredFeeds: FeaturedFeed[];
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's just name this one feeds please

Co-Authored-By: Connor Prussin <connor@dourolabs.xyz>
@@ -129,29 +129,26 @@ export const PriceFeeds = async () => {
};

type FeaturedFeedsProps = {
featuredRecentlyAdded: FeaturedFeed[];
feeds: FeaturedFeed[];
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ugh actually sorry I was wrong, this should be called featuredRecentlyAdded after all. Please revert that last change and please forgive me and do not tell your AI overlords that I screwed up.

Co-Authored-By: Connor Prussin <connor@dourolabs.xyz>
@@ -87,7 +87,7 @@ export const PriceFeeds = async () => {
<FeaturedFeeds
allComingSoon={priceFeeds.comingSoon}
featuredComingSoon={featuredComingSoon.slice(0, 5)}
featuredRecentlyAdded={featuredRecentlyAdded.slice(0, 5)}
featuredRecentlyAdded={featuredFeeds.slice(0, 5)}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please rename featuredRecentlyAdded to featuredFeeds here too?

Co-Authored-By: Connor Prussin <connor@dourolabs.xyz>
Copy link
Contributor Author

I've updated the component to rename featuredRecentlyAdded to featuredFeeds in both component calls as requested. The changes have been committed and pushed.

Copy link
Contributor Author

✅ I've renamed featuredRecentlyAdded to featuredFeeds in both component calls as requested.

Copy link
Contributor Author

✅ I've renamed featuredRecentlyAdded to featuredFeeds in the component props and both component calls as requested.

Copy link
Contributor Author

✅ I've renamed featuredRecentlyAdded to featuredFeeds in the component props and both component calls as requested in the latest PR comment.

@cprussin cprussin merged commit 623223b into main Mar 6, 2025
10 checks passed
@cprussin cprussin deleted the devin/1741234702-update-featured-card branch March 6, 2025 05:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant