-
Notifications
You must be signed in to change notification settings - Fork 267
feat(insights): update Recently Added card to Featured #2445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-Authored-By: Connor Prussin <connor@dourolabs.xyz>
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
title="Recently Added" | ||
icon={<StackPlus />} | ||
title="Featured" | ||
icon={<Star />} | ||
feeds={featuredRecentlyAdded} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update this variable to be named featuredFeeds
instead
Co-Authored-By: Connor Prussin <connor@dourolabs.xyz>
@@ -129,29 +129,29 @@ export const PriceFeeds = async () => { | |||
}; | |||
|
|||
type FeaturedFeedsProps = { | |||
featuredRecentlyAdded: FeaturedFeed[]; | |||
featuredFeeds: FeaturedFeed[]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's just name this one feeds
please
Co-Authored-By: Connor Prussin <connor@dourolabs.xyz>
@@ -129,29 +129,26 @@ export const PriceFeeds = async () => { | |||
}; | |||
|
|||
type FeaturedFeedsProps = { | |||
featuredRecentlyAdded: FeaturedFeed[]; | |||
feeds: FeaturedFeed[]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ugh actually sorry I was wrong, this should be called featuredRecentlyAdded
after all. Please revert that last change and please forgive me and do not tell your AI overlords that I screwed up.
Co-Authored-By: Connor Prussin <connor@dourolabs.xyz>
@@ -87,7 +87,7 @@ export const PriceFeeds = async () => { | |||
<FeaturedFeeds | |||
allComingSoon={priceFeeds.comingSoon} | |||
featuredComingSoon={featuredComingSoon.slice(0, 5)} | |||
featuredRecentlyAdded={featuredRecentlyAdded.slice(0, 5)} | |||
featuredRecentlyAdded={featuredFeeds.slice(0, 5)} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please rename featuredRecentlyAdded
to featuredFeeds
here too?
Co-Authored-By: Connor Prussin <connor@dourolabs.xyz>
I've updated the component to rename |
✅ I've renamed |
✅ I've renamed |
✅ I've renamed |
Update "Recently Added" card to "Featured"
This PR updates the "Recently Added" card and table title to "Featured" in the insights hub price feeds page. It also changes the icon to a star icon from the
@phosphor-icons/react
package.Additionally, it renames the
featuredRecentlyAdded
field tofeaturedFeeds
in the static config and updates the contents of that field with the specified list of price feeds.Changes
featuredRecentlyAdded
field tofeaturedFeeds
in the static configfeaturedFeeds
field with the provided listLink to Devin run: https://app.devin.ai/sessions/f910bfd00da54f2880425242900d27c8
Requested by: Connor