Skip to content

Conversation

aditya520
Copy link
Member

@aditya520 aditya520 commented Aug 28, 2025

Summary

Note:
I managed to add the search in the header, but search server is not giving me any results.
Need help in fixing that.

Rationale

How has this been tested?

  • Current tests cover my changes
  • Added new tests
  • Manually tested the code

Copy link

vercel bot commented Aug 28, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
component-library Ready Ready Preview Comment Sep 3, 2025 10:31am
insights Ready Ready Preview Comment Sep 3, 2025 10:31am
5 Skipped Deployments
Project Deployment Preview Comments Updated (UTC)
api-reference Skipped Skipped Sep 3, 2025 10:31am
developer-hub Skipped Skipped Sep 3, 2025 10:31am
entropy-explorer Skipped Skipped Sep 3, 2025 10:31am
proposals Skipped Skipped Sep 3, 2025 10:31am
staking Skipped Skipped Sep 3, 2025 10:31am

Comment on lines 13 to 23
<Button
onClick={() => {
setOpen(true);
}}
variant="outline"
size="sm"
rounded
beforeIcon={<MagnifyingGlass size={16} />}
>
Search
</Button>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest putting in both variants in

const SearchButtonImpl = (
props: Omit<ButtonProps<typeof UnstyledButton>, "children">,
) => (
<div className={styles.searchButton}>
<Button
className={styles.largeScreenSearchButton ?? ""}
variant="outline"
beforeIcon={<MagnifyingGlass />}
size="sm"
rounded
{...props}
>
<SearchShortcutText />
</Button>
<Button
className={styles.smallScreenSearchButton ?? ""}
hideText
variant="ghost"
beforeIcon={<MagnifyingGlass />}
size="sm"
rounded
{...props}
>
Search
</Button>
</div>
);
along with the css so that you get the responsive button size on smaller screen sizes (maybe we should move that into the component library or make it a default part of the shell...)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll take this

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vercel vercel bot temporarily deployed to Preview – entropy-explorer September 3, 2025 10:28 Inactive
@vercel vercel bot temporarily deployed to Preview – developer-hub September 3, 2025 10:28 Inactive
@vercel vercel bot temporarily deployed to Preview – api-reference September 3, 2025 10:28 Inactive
@vercel vercel bot temporarily deployed to Preview – staking September 3, 2025 10:28 Inactive
@vercel vercel bot temporarily deployed to Preview – proposals September 3, 2025 10:28 Inactive
@aditya520 aditya520 merged commit 5aebc70 into main Sep 3, 2025
10 checks passed
@aditya520 aditya520 deleted the chore(dev-hub)-header-improvements branch September 3, 2025 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants