feat(lazer/js/sdk): QSP auth for browser support #3014
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
5 Skipped Deployments
|
cprussin
approved these changes
Sep 2, 2025
| if (isBrowser()) { | ||
| // Browser: Add token as query parameter | ||
| const urlObj = new URL(url); | ||
| urlObj.searchParams.set("ACCESS_TOKEN", token); |
There was a problem hiding this comment.
If this is available as a query param, why use bearer auth at all? Seems like if you have to support query param auth it's simpler to just always use the query param and never set the header...
There was a problem hiding this comment.
Yeahh, considered that, but we prefer people use the header whenever possible to avoid leaking the token in logs/some nginx somewhere/etc.
| function addAuthentication( | ||
| url: string, | ||
| token: string, | ||
| wsOptions: any = {} |
There was a problem hiding this comment.
In general you shouldn't ever use any; here you should type this correctly to match the types that are valid as options here. If you must, you can use unknown, but I don't think that makes sense in this case.
tejasbadadare
requested review from
ali-behjati and
keyvankhademi
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Rationale
How has this been tested?