feat(pyth-lazer-sui-js): Init Lazer Sui SDK #3017
Conversation
…dsa_update; add workspace entry and docs Co-Authored-By: Tejas Badadare <tejas@dourolabs.xyz>
…ModuleInterop/skipLibCheck Co-Authored-By: Tejas Badadare <tejas@dourolabs.xyz>
…t-config Co-Authored-By: Tejas Badadare <tejas@dourolabs.xyz>
…int-config Co-Authored-By: Tejas Badadare <tejas@dourolabs.xyz>
…-config path Co-Authored-By: Tejas Badadare <tejas@dourolabs.xyz>
…JS and eslint.config.js in lint Co-Authored-By: Tejas Badadare <tejas@dourolabs.xyz>
…fig and in-file ignores Co-Authored-By: Tejas Badadare <tejas@dourolabs.xyz>
…; fix types/imports; remove deprecated .eslintignore Co-Authored-By: Tejas Badadare <tejas@dourolabs.xyz>
… Lazer update -> Sui PTB composition Co-Authored-By: Tejas Badadare <tejas@dourolabs.xyz>
…dd runnable example instructions Co-Authored-By: Tejas Badadare <tejas@dourolabs.xyz>
…tion to SuiRelay example Co-Authored-By: Tejas Badadare <tejas@dourolabs.xyz>
…x imports and README flags Co-Authored-By: Tejas Badadare <tejas@dourolabs.xyz>
…te script and README Co-Authored-By: Tejas Badadare <tejas@dourolabs.xyz>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
tejasbadadare
changed the title
There was a problem hiding this comment.
I'd suggest referring to a newer package like the component library or the sessions sdk for a good example of scaffolding a new package. It looks like a lot of what's in this PR is copied out of legacy packages that aren't well configured and have a lot of small issues. Let me know if it would help to pair up on this and I'm happy to lend a hand
| import { Transaction } from "@mysten/sui/transactions"; | ||
| import { SUI_CLOCK_OBJECT_ID } from "@mysten/sui/utils"; | ||
|
|
||
| const MAX_ARGUMENT_SIZE = 16 * 1024; |
There was a problem hiding this comment.
Super minor and not worth changing, but one thing I really like to do with consts like this is break them down with units so it's super easy to understand where the numbers come from, e.g. something like this:
const ONE_KIBIBYTE_IN_BYTES = 1024;
const MAX_ARGUMENT_SIZE_IN_BYTES = 16 * ONE_KIBIBYTE_IN_BYTES;(I'm assuming that's where 1024 comes from but I don't know where 16 comes from)
There was a problem hiding this comment.
Actually realized this might be an old requirement imposed by WH, idt we need it anymore
| tx: Transaction; | ||
| packageId: string; | ||
| stateObjectId: string; | ||
| updateBytes: Buffer; |
There was a problem hiding this comment.
Note that Buffer is not available in browsers without a polyfill, you might want to consider using Uint8Array instead which is a superclass of Buffer and would make the code more easily isomorphic, if that's something you care about and you aren't using anything specific to Buffer (I don't think you are)
There was a problem hiding this comment.
Ahhh ok cool. Sui examples use Buffer but idt it's actually needed by their API.
Summary
Create a Lazer Sui SDK to enable users to create txns to parse and verify Lazer payloads on-chain.
packageIdisn't automatically handled by the SDK. This will be added once we handle upgrades in the Sui contract.Testing