-
Notifications
You must be signed in to change notification settings - Fork 298
chore(developer-hub): enhancements in the express relay #3034
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest updates on your projects. Learn more about Vercel for GitHub.
5 Skipped Deployments
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good overall, a few suggestions
apps/developer-hub/content/docs/express-relay/how-express-relay-works/auction.mdx
Outdated
Show resolved
Hide resolved
apps/developer-hub/content/docs/express-relay/how-express-relay-works/index.mdx
Outdated
Show resolved
Hide resolved
@@ -1,204 +1,31 @@ | |||
--- | |||
title: "Error Codes" | |||
title: "SVM Error Codes" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe this should be Express Relay Error Codes
instead? I feel like SVM Error Codes is too generic but feel free to ignore if it doesn't make sense
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As we are inside Express Relay, SVM Error Codes seems okay to me.
apps/developer-hub/content/docs/express-relay/how-express-relay-works/index.mdx
Outdated
Show resolved
Hide resolved
eeb707d
to
da21bea
Compare
<Callout variant="warning"> | ||
To simulate real performance conditions and activity, the staging/testing | ||
environment for Solana is on the mainnet-beta network. This environment is not | ||
for production use and should only be used for testing. | ||
</Callout> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using a Callout which seems much better.
Summary
Matching the content with the docs.
Rationale
How has this been tested?