fix(dev hub): ui fixes #3050
fix(dev hub): ui fixes #3050
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
5 Skipped Deployments
|
| <AppShellRoot | ||
| enableAccessibilityReporting={enableAccessibilityReporting} | ||
| amplitudeApiKey={amplitudeApiKey} | ||
| googleAnalyticsId={googleAnalyticsId} | ||
| providers={providers} | ||
| > | ||
| <AppBody {...props} /> | ||
| </AppShellRoot> |
There was a problem hiding this comment.
Split the AppShell into 2 components so we can have the fumadocs provider after <body> but before the App Shell header
| } | ||
|
|
||
| .prose p + ul, | ||
| .prose p + ol { |
There was a problem hiding this comment.
this reduces list paddings
also there's no cleaner way to change the default styles other than globally styling cc #3031 (comment)
There was a problem hiding this comment.
Maybe add a comment around all this to explain why we're using global styles? The thing to avoid is some dev coming along, seeing this, and thinking it's OK to use global styles
There was a problem hiding this comment.
Maybe even move this stuff to a separate file and import it, something like fumadocs-global-styles-override.scss with a big scary comment at the top
| } | ||
|
|
||
| .prose p + ul, | ||
| .prose p + ol { |
| } | ||
|
|
||
| .prose p + ul, | ||
| .prose p + ol { |
There was a problem hiding this comment.
Maybe add a comment around all this to explain why we're using global styles? The thing to avoid is some dev coming along, seeing this, and thinking it's OK to use global styles
| } | ||
|
|
||
| .prose p + ul, | ||
| .prose p + ol { |
There was a problem hiding this comment.
Maybe even move this stuff to a separate file and import it, something like fumadocs-global-styles-override.scss with a big scary comment at the top
Summary
Rationale
How has this been tested?