chore(developer-hub): reward calculator and image import in ois #3057
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
nidhi-singh02
changed the title
nidhi-singh02
force-pushed
the
reward-cal
branch
from
98ff252 to
3a9689c
Compare
nidhi-singh02
commented
Sep 17, 2025
Comment on lines
25
to
36
| const RewardSimulator: React.FC = () => { | ||
| const [publisherStake, setPublisherStake] = useState(200); | ||
| const [delegatorStake, setDelegatorStake] = useState(300); | ||
| const [maxCap, setMaxCap] = useState(500); | ||
| const [delegatorFee, setDelegatorFee] = useState(20); | ||
| const [rewardRate, setRewardRate] = useState(10); | ||
|
|
||
| const [publisherReward, setPublisherReward] = useState(0); | ||
| const [delegatorReward, setDelegatorReward] = useState(0); | ||
| const [publisherRewardRate, setPublisherRewardRate] = useState(0); | ||
| const [delegatorRewardRate, setDelegatorRewardRate] = useState(0); | ||
|
|
There was a problem hiding this comment.
this file is referred from the reward simulator of the documentation.
nidhi-singh02
commented
Sep 17, 2025
Comment on lines
+9
to
+14
| import OISSlashingInvestigationDark from "./images/ois_slashing_investigation_dark.png"; | ||
| import OISSlashingInvestigationLight from "./images/ois_slashing_investigation_light.png"; | ||
| import OISSlashingPoolPreDark from "./images/ois_slashing_pool_pre_dark.png"; | ||
| import OISSlashingPoolPreLight from "./images/ois_slashing_pool_pre_light.png"; | ||
| import OISSlashingPoolPostDark from "./images/ois_slashing_pool_post_dark.png"; | ||
| import OISSlashingPoolPostLight from "./images/ois_slashing_pool_post_light.png"; |
There was a problem hiding this comment.
using image import and moved the images from the public folder inside the folder where they are used.
alexcambose
previously requested changes
Sep 17, 2025
apps/developer-hub/src/components/RewardSimulator/index.module.scss
Outdated
Show resolved
Hide resolved
cprussin
previously requested changes
Sep 17, 2025
apps/developer-hub/src/components/RewardSimulator/index.module.scss
Outdated
Show resolved
Hide resolved
apps/developer-hub/src/components/RewardSimulator/index.module.scss
Outdated
Show resolved
Hide resolved
apps/developer-hub/src/components/RewardSimulator/index.module.scss
Outdated
Show resolved
Hide resolved
alexcambose
reviewed
Sep 18, 2025
nidhi-singh02
force-pushed
the
reward-cal
branch
from
b640939 to
84350cc
Compare
alexcambose
previously approved these changes
Sep 18, 2025
This reverts commit 84350cc.
cprussin
approved these changes
Sep 18, 2025
Comment on lines
+33
to
+46
| $font-family: ( | ||
| "monospace": ( | ||
| "ui-monospace", | ||
| "sfmono-regular", | ||
| "consolas", | ||
| "Liberation Mono", | ||
| "menlo", | ||
| "monospace", | ||
| ), | ||
| ); | ||
|
|
||
| @function font-family($family) { | ||
| @return map-get-strict($font-family, $family); | ||
| } |
There was a problem hiding this comment.
I think this is great but at some point we should probably have a specific font we ship for mono text, cc @partyparrotgreg not sure if you already have one in mind
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Rationale
How has this been tested?