-
Notifications
You must be signed in to change notification settings - Fork 297
chore(developer-hub): remove all the kpi pages by month and redirect from home #3068
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest updates on your projects. Learn more about Vercel for GitHub.
5 Skipped Deployments
|
<Callout variant="warning" header="Disclaimer"> | ||
All figures mentioned are just rough estimations. Due to Pyth's permissionless | ||
nature, any apps can use the Pyth price feeds without talking to the Pyth | ||
contributors. This will exclude them from the calculations. | ||
</Callout> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mdx apparently adds a <p>
around content which makes the spacing big, you might want to wrap the content with a <div>
like https://github.com/pyth-network/pyth-crosschain/blob/main/apps/developer-hub/content/docs/price-feeds/v1/create-your-first-pyth-app.mdx?plain=1#L17-L21
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried wrapping the content with a
<div>
wrapped over <p>
in both the cases.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed, removing the new line between the div,<div>content</div>
makes it work, but the linter is complaining. @alexcambose will find a fix for this. going to merge this.
Summary
Rationale
How has this been tested?