Skip to content

Conversation

nidhi-singh02
Copy link
Contributor

@nidhi-singh02 nidhi-singh02 commented Sep 19, 2025

Summary

  • Remove all the old kpi pages from 2021, as not needed.
  • Added link to the kpi page with enhanced visuals.
  • Enhanced disclaimer visuals.

Rationale

How has this been tested?

  • Current tests cover my changes
  • Added new tests
  • Manually tested the code
image

Copy link

vercel bot commented Sep 19, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
component-library Ready Ready Preview Comment Sep 19, 2025 8:02am
developer-hub Ready Ready Preview Comment Sep 19, 2025 8:02am
5 Skipped Deployments
Project Deployment Preview Comments Updated (UTC)
api-reference Skipped Skipped Sep 19, 2025 8:02am
entropy-explorer Skipped Skipped Sep 19, 2025 8:02am
insights Skipped Skipped Sep 19, 2025 8:02am
proposals Skipped Skipped Sep 19, 2025 8:02am
staking Skipped Skipped Sep 19, 2025 8:02am

Comment on lines +13 to +17
<Callout variant="warning" header="Disclaimer">
All figures mentioned are just rough estimations. Due to Pyth's permissionless
nature, any apps can use the Pyth price feeds without talking to the Pyth
contributors. This will exclude them from the calculations.
</Callout>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mdx apparently adds a <p> around content which makes the spacing big, you might want to wrap the content with a <div> like https://github.com/pyth-network/pyth-crosschain/blob/main/apps/developer-hub/content/docs/price-feeds/v1/create-your-first-pyth-app.mdx?plain=1#L17-L21

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried wrapping the content with a

I still see a big margin. Also inspected the reference of create your app, seems the margin is same and I see <div> wrapped over <p> in both the cases.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed, removing the new line between the div,<div>content</div> makes it work, but the linter is complaining. @alexcambose will find a fix for this. going to merge this.

@nidhi-singh02 nidhi-singh02 merged commit 13018c4 into main Sep 19, 2025
10 checks passed
@nidhi-singh02 nidhi-singh02 deleted the kpi-enhancements branch September 19, 2025 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants