fix: Exclude feeds for which there are product accounts but no price account #3076
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fhqvst
force-pushed
the
fhqvst/ui-241-publisher-page-throwing-errors-in-conformance-cluster
branch
2 times, most recently
from
bf11ef9 to
e151575
Compare
|
The latest updates on your projects. Learn more about Vercel for GitHub.
5 Skipped Deployments
|
fhqvst
force-pushed
the
fhqvst/ui-241-publisher-page-throwing-errors-in-conformance-cluster
branch
from
e151575 to
b9f85f0
Compare
fhqvst
changed the title
alexcambose
approved these changes
Sep 24, 2025
fhqvst
deleted the
fhqvst/ui-241-publisher-page-throwing-errors-in-conformance-cluster
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
While uncommon, there are indeed cases where we create a product account and then fail to create price account. In such cases the
price_accountfield (plus a few others) will beundefined, which breaks thezodschema.Typically we'd remove these products manually, but we might as well just filter them out.
How has this been tested?