Fixed tab completion crash on Windows #1014
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tleonhardt
approved these changes
Nov 11, 2020
|
|
||
| # Print any metadata like a hint or table header | ||
| readline.rl.mode.console.write(sys.stdout.write(self._build_completion_metadata_string())) | ||
| readline.rl.mode.console.write(self._build_completion_metadata_string()) |
There was a problem hiding this comment.
As long as the tests still pass on Linux/TravisCI then it looks good to me
Codecov Report
@@ Coverage Diff @@
## master #1014 +/- ##
=======================================
Coverage 97.89% 97.89%
=======================================
Files 22 22
Lines 4613 4613
=======================================
Hits 4516 4516
Misses 97 97
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1013