Skip to content

Fixed tab completion crash on Windows #1014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 11, 2020
Merged

Fixed tab completion crash on Windows #1014

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## 1.4.0 (TBD XX, 2020)
* Bug Fixes
* Fixed tab completion crash on Windows

## 1.3.11 (October 1, 2020)
* Bug Fixes
* Fixed issue where quoted redirectors and terminators in aliases and macros were not being
Expand Down
2 changes: 1 addition & 1 deletion cmd2/cmd2.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1590,7 +1590,7 @@ def _display_matches_pyreadline(self, matches: List[str]) -> None: # pragma: no
matches_to_display, _ = self._pad_matches_to_display(matches_to_display)

# Print any metadata like a hint or table header
readline.rl.mode.console.write(sys.stdout.write(self._build_completion_metadata_string()))
readline.rl.mode.console.write(self._build_completion_metadata_string())
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As long as the tests still pass on Linux/TravisCI then it looks good to me


# Display matches using actual display function. This also redraws the prompt and line.
orig_pyreadline_display(matches_to_display)
Expand Down