Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add LT and GT to supported otn chars #595

Merged
merged 1 commit into from
Sep 28, 2021
Merged

Add LT and GT to supported otn chars #595

merged 1 commit into from
Sep 28, 2021

Conversation

ChrisLovering
Copy link
Member

Does what it says on the tin.

@ChrisLovering ChrisLovering mentioned this pull request Sep 27, 2021
Merged
@ChrisLovering ChrisLovering force-pushed the add-more-supported-symbols-to-otn branch from 5a40f84 to f05f40f Compare September 27, 2021 20:39
@coveralls
Copy link

coveralls commented Sep 27, 2021 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling 3cb0a6b on add-more-supported-symbols-to-otn into 59422be on main.

onerandomusername
onerandomusername reviewed Sep 27, 2021
View reviewed changes
Copy link
Contributor

@onerandomusername onerandomusername left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these the best unicode characters for this?

\u276e and \u276f might be better looking substitutes.

onerandomusername
onerandomusername approved these changes Sep 27, 2021
View reviewed changes
Copy link
Contributor

@onerandomusername onerandomusername left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looked at what they all look like on discord, these are the best characters for this purpose.

@ChrisLovering ChrisLovering force-pushed the add-more-supported-symbols-to-otn branch from f05f40f to dd76953 Compare September 27, 2021 20:47
@ChrisLovering ChrisLovering force-pushed the add-more-supported-symbols-to-otn branch from dd76953 to 3cb0a6b Compare September 27, 2021 20:51
@onerandomusername
Copy link
Contributor

What were all of the force pushes for? I don't see any difference since the last time I reviewed it.

@ChrisLovering
Copy link
Member Author

What were all of the force pushes for? I don't see any difference since the last time I reviewed it.

renamed the migration file, since it had it's auto generated name

@onerandomusername
Copy link
Contributor

gotcha

@Akarys42 Akarys42 merged commit b2f12ac into main Sep 28, 2021
@Akarys42 Akarys42 deleted the add-more-supported-symbols-to-otn branch September 28, 2021 15:11
@D0rs4n D0rs4n mentioned this pull request Oct 18, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@D0rs4n D0rs4n D0rs4n approved these changes

@Akarys42 Akarys42 Akarys42 approved these changes

@onerandomusername onerandomusername onerandomusername approved these changes

@Den4200 Den4200 Awaiting requested review from Den4200

@MarkKoz MarkKoz Awaiting requested review from MarkKoz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ChrisLovering @coveralls @onerandomusername @D0rs4n @Akarys42