Skip to content

Add LT and GT to supported otn chars#1848

Merged
Akarys42 merged 1 commit into
mainfrom
add-more-supported-symbols-to-otn
Sep 28, 2021
Merged

Add LT and GT to supported otn chars#1848
Akarys42 merged 1 commit into
mainfrom
add-more-supported-symbols-to-otn

Conversation

@ChrisLovering
Copy link
Copy Markdown
Member

Does what it says on the tin.
python-discord/site#595 must be merged first

Comment thread bot/converters.py Outdated
"""
if from_unicode:
table = str.maketrans(cls.ALLOWED_CHARACTERS, '𝖠𝖡𝖢𝖣𝖤𝖥𝖦𝖧𝖨𝖩𝖪𝖫𝖬𝖭𝖮𝖯𝖰𝖱𝖲𝖳𝖴𝖵𝖶𝖷𝖸𝖹ǃ?’’-')
table = str.maketrans(cls.ALLOWED_CHARACTERS, '𝖠𝖡𝖢𝖣𝖤𝖥𝖦𝖧𝖨𝖩𝖪𝖫𝖬𝖭𝖮𝖯𝖰𝖱𝖲𝖳𝖴𝖵𝖶𝖷𝖸𝖹ǃ?’’-<>')
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this second string be a constant since its in two places?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since I'm here, why not. Force pushed

@ChrisLovering ChrisLovering force-pushed the add-more-supported-symbols-to-otn branch from 22ca3a8 to c04832f Compare September 27, 2021 20:43
Copy link
Copy Markdown
Contributor

@onerandomusername onerandomusername left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Contributor

@Akarys42 Akarys42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Akarys42 Akarys42 enabled auto-merge September 28, 2021 15:12
@Akarys42 Akarys42 merged commit 62aceb8 into main Sep 28, 2021
@Akarys42 Akarys42 deleted the add-more-supported-symbols-to-otn branch September 28, 2021 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants