Make the examples way better #35
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… stuff. this needs to be refactored into more modules and cleaned up.
…mmon tests are shared
radix
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The github example is all basically mashed into one place, and it poorly represents all the separation of concerns that Effect encourages by separating performers and application code.
Also, it doesn't work on Python 3, and it doesn't support non-Twisted performing, which leads people to think that Effect only works with Twisted.
It should be refactored to show that core application logic can stay the same (i.e. the flow of asking a user for their GH username, fetching their repositories and displaying them), and used with different performers like the Twisted ones and blocking ones.