Skip to content

Microsoft Teams Bot! #754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Microsoft Teams Bot! #754

wants to merge 2 commits into from

Conversation

prokan468
Copy link

Microsoft Teams Bot -
I can bet I am no the only 1 missing classes due to the pandemic. Hence I created a bot that joins my classes and I thought I can share this Automation with everyone. This is Automation in Microsoft Teams!

Instructions
Edit the YAML file, and add your timetable, username, password.
Go to line 18,124 and 146 of the Python File and add the location of the images and the settings file.

Self Check(Tick After Making pull Request)

  • This issue was assigned to me.
  • One Change in one Pull Request
  • My file is in proper folder (Name of folder should be in lowercase with no space in between) (E.g. meet_schedular)
  • I am following clean code and Documentation and my code is well linted with flake8.
  • I have added README.md and requirements.txt (Include version numbers too e.g. pandas==0.0.1) with my script
  • I have used REPO README TEAMPLATE (Necessary)
  • Just including required dependencies in requirements.txt (Don't include Python version too)

#753

This code file automates the process of joining classes and leaving classes according to the time table provided in the YAML file.
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congratulations!! 🎉 @prokan468 for making your first PR. We will review the changes soon and merge finally.😊 Do give a star ⭐ meanwhile if you like this project.

@pawangeek
Copy link
Contributor

Add Readme and reuirements.txt files

@pawangeek pawangeek linked an issue Oct 11, 2021 that may be closed by this pull request
3 tasks
@pawangeek
Copy link
Contributor

FIx the linting and rename folder to 'msteams_meetjoiner'

Copy link

@alfawal alfawal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just code reviewing.
Some changes will improve the quality.

Comment on lines +17 to +18
settings_path = "D:\Desktop\Python Documents\TeamsProject\settings.yaml"
with open(settings_path) as f:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, not everyone has this directory.
Pass ./settings.yaml directly into the open function.
Alternatively you can use os.path.abspath() or pathlib's Path().absolute().

Comment on lines +17 to +18
settings_path = "D:\Desktop\Python Documents\TeamsProject\settings.yaml"
with open(settings_path) as f:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, not everyone has the same directory.
Pass ./settings.yaml directly into open().
Alternatively, you can use os.path.abspath() or pathlib's Path().absolute().

global driver
options = webdriver.ChromeOptions()
options.add_experimental_option('excludeSwitches', ['enable-logging'])
driver = webdriver.Chrome(executable_path="C:\Program Files (x86)\chromedriver.exe", options=options)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure if this repo has any instructors about having a single webdriver and where but this is also the same issue as the previous one.



def allow():
perm = magic.locateCenterOnScreen('D:\Desktop\Python Documents\TeamsProject\core\llow.png')
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use absolute path here as well.

Comment on lines +44 to +54
time.sleep(1)
passentry()
time.sleep(1)
findingcal()
time.sleep(1)
findingactivejoinbutton()
time.sleep(1)
allow()
time.sleep(1)
finaljoin()
time.sleep(1)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would work (not always), it's always a good practice to wait the page to load specific elements instead of waiting 1 second.

driver.find_element_by_class_name("button-col").click()


checkingforday()
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

consider adding if __name__ == "__main__" in all of your python files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automate Joining Meeting in Microsoft Teams
3 participants