Skip to content
This repository was archived by the owner on Jan 13, 2021. It is now read-only.

Work around cryptography support in old PyPy #163

Merged
merged 1 commit into from
Aug 28, 2015
Merged

Conversation

Lukasa
Copy link
Member

@Lukasa Lukasa commented Aug 28, 2015

Fixes #161.

Lukasa added a commit that referenced this pull request Aug 28, 2015
Work around cryptography support in old PyPy
@Lukasa Lukasa merged commit a12ebb4 into development Aug 28, 2015
@sigmavirus24
Copy link
Contributor

Word of caution: This will not work for wheels.

@Lukasa Lukasa deleted the fix-pypy branch August 28, 2015 14:46
@Lukasa
Copy link
Member Author

Lukasa commented Aug 28, 2015

Yeah. =( Frankly, the setup.py in this module is being a little bit over-clever, but I'm not really confident that we can do anything else.

@sigmavirus24
Copy link
Contributor

Specifically what I meant is the following:

If you build a wheel on CPython 2.7, the requirements will statically say "cryptography 1.0 is okay" and someone installing that wheel on PyPy < 2.6.0 will get that requirement and it will cause them to install 1.0 and for things to be broken.

I would be careful about publishing wheels at this point because of this.

@Lukasa
Copy link
Member Author

Lukasa commented Aug 30, 2015

Yeah, I got that.

What I mean is that the setup.py has a number of flaws exactly like that, because I publish universal wheels. This is altogether somewhat problematic.

@sigmavirus24
Copy link
Contributor

Yeah, I would say you should stop publishing universal wheels because of this =(. pip 7.x.y will build wheels and cache them for you so they'll be 100% appropriate for each user.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants