This repository has been archived by the owner on Jan 13, 2021. It is now read-only.
Add content-length header for http2 connections #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this @natemara! The test troubles are interesting, I've got a suspicion they're timing related, but I'll try to take a look and see if I can fix them so that we can write some tests for this. |
|
Yes, I'm working on the development branch, with up to #205. |
|
Hmm, that's perplexing. What's your environment? What Python are you using, what OpenSSL etc.? |
|
@natemara Do you want to try rebasing onto the current development branch and try again? |
If a body is defined, we should be sending a Content-Length header unless the request has the Transfer-Encoding header is set. This should fix #206.
|
Alright, that's rebased and checking now. |
|
Ok, so this is doing better. There are two things that need to be solved:
Both of those will need to be fixed up. =) You up for doing that @natemara? |
| @@ -170,6 +170,8 @@ def request(self, method, url, body=None, headers={}): | |||
| # Convert the body to bytes if needed. | |||
| if body and isinstance(body, (unicode, bytes)): | |||
| body = to_bytestring(body) | |||
| if 'Transfer-Encoding' not in headers.keys(): | |||
There was a problem hiding this comment.
Any reason why we need O(n) here? Would it be better to just use:
if 'Transfer-Encoding' not in headers:
....
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a body is defined, we should be sending a Content-Length header unless the request has the Transfer-Encoding header is set. This should fix #206. I was having some difficulty running the tests, but it seems like that was mostly related to SSL certificate problems. Looking at the spec doc, it says that clients SHOULD send the Content-Length header when there is no Transfer-Encoding header set.