This repository was archived by the owner on Jan 13, 2021. It is now read-only.
removing stream from recent_recv_streams on clean close #270
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this! I'm happy with the change, and have no objection to that test, but I'd also like a more specific test. Can we write a test that cleanly closes one stream? That is, that uses a stream through its lifetime, such that it gets a complete response, and then confirms that it has been removed from everything? |
|
Were you looking for something more along the lines of this? This is what I originally wrote but felt it might exercise unnecessary code. |
|
Yup @nateprewitt, that looks right. |
nateprewitt
force-pushed
the
265_remove_stream_on_close
branch
2 times, most recently
from
e15eeb1 to
9620d4f
Compare
nateprewitt
force-pushed
the
265_remove_stream_on_close
branch
from
9620d4f to
90b43a3
Compare
|
Replaced old test with lifecycle test. The former felt redundant with this one. |
|
Fab, thanks @nateprewitt! ✨ 🍰 ✨ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses #265. Not sure if the test is overkill for such a minor change, but I figured I'd err on the side of 101% coverage :) I'll strip it out if it's unneeded.