This repository was archived by the owner on Jan 13, 2021. It is now read-only.
Fix upgrading to h2c #313
Merged
Fix upgrading to h2c #313
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #312
Lukasa
suggested changes
Mar 4, 2017
| # Check that the response is OK and that we did upgrade to HTTP/2. | ||
| assert response.status == 200 | ||
| assert response.read() | ||
| assert response.version == HTTPVersion.http20 |
There was a problem hiding this comment.
So this is a great test, thanks. But the release tests are generally allowed to fail because Travis sucks at running tests with real networks. Can you write a test in test_integration.py or test_integration_http11.py as well to ensure that this works properly?
There was a problem hiding this comment.
I did change test_integration_http11.py in such a way that it fails without my fix. Do you think something else is necessary?
There was a problem hiding this comment.
Oh, no, sorry, I just wasn't paying enough attention there. My bad!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #312