This repository was archived by the owner on Jan 13, 2021. It is now read-only.
Fix the documentation on overriding the SSL context #316
+7
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I completely botched that one. It seemed to work, but it was falling back to HTTP/1.1. And I missed hyper.tls.init_context.
|
😉 No worries: I do know about TLS and missed it in code review, so you don't need to beat yourself up too much. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry, I completely botched #315. It seemed to work, but it was falling back to HTTP/1.1, which is definitely not what most people would want. And I missed
hyper.tls.init_context. Hopefully this version is more correct, but it’s not like I know what I’m doing when it comes to TLS :/