This repository was archived by the owner on Jan 13, 2021. It is now read-only.
Add read-ahead logic. #76
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I also suspect this build will fail. |
| if self._bytes_in_buffer: | ||
| return True | ||
|
|
||
| read = select.select([self._sck], [], [], 0)[0] |
There was a problem hiding this comment.
This won't work on Windows according to the docs. You might want to document that
There was a problem hiding this comment.
Why not? We're using sockets here, so it should be fine.
There was a problem hiding this comment.
Ignore me. I need more ☕
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my proposed synchronous solution to #65. It involves optimistically reading up to 9 extra frames from the connection each time we read a single frame.
The logic continues to implement a 'block until at least one frame is read' behaviour. That's important, we rely on that blocking IO (though arguably we shouldn't). We then read up to 9 more frames without blocking.
This is not quite complete, I need to do a bit more of a refactor to finish this off.