Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The library is vulnerable to a denial of service attack whereby a remote peer
can insert an unbounded number of streams into the priority tree. This consumes
unbounded memory and also increasingly large amounts of CPU, which can
lead to a trivial denial of service against a HTTP/2 server. This vulnerability
is part of a class of vulnerabilities originally reported in this report,
under the section "Victim 3-Dependency and Priority". The document notes in
passing that the dependency tree size is not limited, and that "a server that
naively trusts the client may be foiled to build a dependency tree that will
consume its memory". This is exactly the attack that the priority library is
exposed to.
Sample code to reproduce the vulnerability is below:
This code will run indefinitely, and eventually exhaust the memory available
to it.