Skip to content

Conversation

gjo
Copy link
Contributor

@gjo gjo commented Dec 2, 2019

webob (used by pyramid) 's multidict protocol does not have getlist method, use getall instead of getlist.

@codecov
Copy link

codecov bot commented Dec 2, 2019

Codecov Report

Merging #173 into master will decrease coverage by 0.09%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #173     +/-   ##
=========================================
- Coverage   96.72%   96.62%   -0.1%     
=========================================
  Files          71       71             
  Lines        1770     1721     -49     
=========================================
- Hits         1712     1663     -49     
  Misses         58       58
Impacted Files Coverage Δ
openapi_core/schema/schemas/_format.py 89.7% <0%> (-1.21%) ⬇️
openapi_core/contrib/flask/requests.py 91.66% <0%> (-0.65%) ⬇️
openapi_core/schema/links/generators.py 92% <0%> (-0.6%) ⬇️
openapi_core/schema/parameters/enums.py 93.75% <0%> (-0.37%) ⬇️
openapi_core/schema/schemas/exceptions.py 87.27% <0%> (-0.23%) ⬇️
openapi_core/schema/parameters/models.py 97.22% <0%> (-0.12%) ⬇️
openapi_core/schema/specs/models.py 95.45% <0%> (-0.11%) ⬇️
openapi_core/schema/schemas/models.py 95.28% <0%> (-0.03%) ⬇️
openapi_core/schema/responses/generators.py 100% <0%> (ø) ⬆️
openapi_core/contrib/django/responses.py 100% <0%> (ø) ⬆️
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8152d20...9bd5a1d. Read the comment docs.

@p1c2u p1c2u merged commit 4b712cb into python-openapi:master Jan 13, 2020
@gjo
Copy link
Contributor Author

gjo commented Jan 13, 2020

thx!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants