Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dataclasses refactor #345

Merged
merged 1 commit into from
May 29, 2021
Merged

Dataclasses refactor #345

merged 1 commit into from
May 29, 2021

Conversation

p1c2u
Copy link
Collaborator

@p1c2u p1c2u commented May 24, 2021

Changes:

  • get rid of attrs and use dataclasses backport for python 3.6

Backward incompatibilities:

  • RequestParameters' header attribute as Headers type
  • RequestParameters' cookie attribute as ImmutableMultiDict type
  • unused server, operation and path attributes removed from RequestValidationResult

@codecov
Copy link

codecov bot commented May 24, 2021

Codecov Report

Merging #345 (30d0f06) into master (e9e43eb) will increase coverage by 0.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #345      +/-   ##
==========================================
+ Coverage   95.77%   95.84%   +0.06%     
==========================================
  Files          78       78              
  Lines        1609     1635      +26     
==========================================
+ Hits         1541     1567      +26     
  Misses         68       68              
Impacted Files Coverage Δ
openapi_core/casting/schemas/exceptions.py 100.00% <100.00%> (ø)
openapi_core/contrib/django/requests.py 100.00% <100.00%> (ø)
openapi_core/contrib/django/responses.py 100.00% <100.00%> (ø)
openapi_core/contrib/falcon/requests.py 100.00% <100.00%> (ø)
openapi_core/contrib/falcon/responses.py 92.85% <100.00%> (+1.19%) ⬆️
openapi_core/contrib/flask/requests.py 94.11% <100.00%> (+0.78%) ⬆️
openapi_core/contrib/flask/responses.py 100.00% <100.00%> (ø)
openapi_core/contrib/requests/requests.py 100.00% <100.00%> (ø)
openapi_core/contrib/requests/responses.py 100.00% <100.00%> (ø)
openapi_core/deserializing/exceptions.py 87.50% <100.00%> (ø)
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e9e43eb...30d0f06. Read the comment docs.

@p1c2u p1c2u force-pushed the refactor/dataclasses-refactor branch from 251b972 to 6cd8715 Compare May 24, 2021 22:02
@p1c2u p1c2u force-pushed the refactor/dataclasses-refactor branch from 6cd8715 to 30d0f06 Compare May 29, 2021 14:29
@p1c2u p1c2u merged commit 4a7f88b into master May 29, 2021
@p1c2u p1c2u deleted the refactor/dataclasses-refactor branch May 29, 2021 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant