Fix a DeprecationWarning from aiohttp in TestPetPhotoView #836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The warning says, “In v4, passing bytes will no longer create a file field. Please explicitly use the filename parameter or pass a BytesIO object.” This commit implements the latter approach.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #836 +/- ##
==========================================
+ Coverage 90.26% 90.28% +0.02%
==========================================
Files 147 148 +1
Lines 4302 4313 +11
Branches 524 527 +3
==========================================
+ Hits 3883 3894 +11
Misses 317 317
Partials 102 102 ☔ View full report in Codecov by Sentry. |
|
I failed to reference the bug that this fixes: #835 |
|
@musicinmybrain thanks for the contribution |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The warning says, “In v4, passing bytes will no longer create a file field. Please explicitly use the filename parameter or pass a BytesIO object.” This commit implements the latter approach.