Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sphinx errors on Travis CI #1541

Closed
hugovk opened this issue Nov 17, 2015 · 6 comments
Closed

Sphinx errors on Travis CI #1541

hugovk opened this issue Nov 17, 2015 · 6 comments
Labels
Bug Any unexpected behavior, until confirmed feature. Build

Comments

@hugovk
Copy link
Member

hugovk commented Nov 17, 2015

It's not causing builds to fail, but pushd docs; make html; make linkcheck; popd results in errors in the log:

https://travis-ci.org/python-pillow/Pillow/jobs/91335318#L2493

0.72s$ pushd docs; make html; make linkcheck; popd
~/build/python-pillow/Pillow/docs ~/build/python-pillow/Pillow
sphinx-build -b html -d _build/doctrees   . _build/html
Running Sphinx v1.3.1
making output directory...
Exception occurred:
  File "conf.py", line 59, in <module>
    import PIL
ImportError: No module named PIL
The full traceback has been saved in /tmp/sphinx-err-awRHdU.log, if you want to report the issue to the developers.
Please also report this if it was a user error, so that a better error message can be provided next time.
A bug report can be filed in the tracker at <https://github.com/sphinx-doc/sphinx/issues>. Thanks!
make: *** [html] Error 1
sphinx-build -b linkcheck -d _build/doctrees   . _build/linkcheck
Running Sphinx v1.3.1
making output directory...
Exception occurred:
  File "conf.py", line 59, in <module>
    import PIL
ImportError: No module named PIL
The full traceback has been saved in /tmp/sphinx-err-7PDKSC.log, if you want to report the issue to the developers.
Please also report this if it was a user error, so that a better error message can be provided next time.
A bug report can be filed in the tracker at <https://github.com/sphinx-doc/sphinx/issues>. Thanks!
make: *** [linkcheck] Error 1
~/build/python-pillow/Pillow

cc @aclark4life

@hugovk hugovk added Bug Any unexpected behavior, until confirmed feature. Build labels Nov 17, 2015
@aclark4life
Copy link
Member

Does it happen local for anyone?

@wiredfool
Copy link
Member

I think what's happening here is that Travis is doing an inplace build, so, from the root of the Pillow directory you can import PIL and have it work. We then cd into the docs directory and try to import PIL, and since we aren't in the package root, it fails.

The best case would probably be to install into a virtualenv and build against that. Alternately, we could monkey around with the import path for sphinx to get it to recognize where Pillow is.

@aclark4life
Copy link
Member

We could also move the documentation out of Pillow, if anyone is in to that idea... that would make it "clean" (but also create more work in the process, which I probably don't mind if there is interest in doing it that way.)

@wiredfool
Copy link
Member

I'd like to keep the docs in the same repo for management and pr purposes. If we get new features from someone, I'd like to keep it as easy as possible to add documentation as well.

@aclark4life
Copy link
Member

Cool, fine with me.

@radarhere
Copy link
Member

From my understanding, this has been resolved by #1655

@hugovk hugovk closed this as completed Jan 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Any unexpected behavior, until confirmed feature. Build
Projects
None yet
Development

No branches or pull requests

4 participants