Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check all the mallocs #1715

Closed
wiredfool opened this issue Feb 4, 2016 · 0 comments
Closed

Check all the mallocs #1715

wiredfool opened this issue Feb 4, 2016 · 0 comments
Labels
Preventative Maintenance

Comments

@wiredfool
Copy link
Member

We should check all mallocs in the code base for:

  • parameters should be a size_t /py_size_t
  • any parameter that is potentially attacker supplied should be sanatized. If there is a problem, return with an error -- either ImagingError_ValueError or a memory error, as appropriate.
  • See if calloc is a reasonable substitution.
  • make sure that the return value is checked for success.
@wiredfool wiredfool mentioned this issue Mar 16, 2016
Merged
wiredfool added a commit to wiredfool/Pillow that referenced this issue Mar 16, 2016
@wiredfool
Malloc check, python-pillow#1715
5851e56
wiredfool added a commit to wiredfool/Pillow that referenced this issue Mar 18, 2016
@wiredfool
Malloc check, python-pillow#1715
e388a6c
wiredfool added a commit to wiredfool/Pillow that referenced this issue Mar 18, 2016
@wiredfool
Malloc check, realloc, python-pillow#1715
65963c1
wiredfool added a commit to wiredfool/Pillow that referenced this issue Mar 18, 2016
@wiredfool
Malloc check, python-pillow#1715
feade99
wiredfool added a commit to wiredfool/Pillow that referenced this issue Mar 18, 2016
@wiredfool
Malloc check, python-pillow#1715
1e1a7a1
wiredfool added a commit to wiredfool/Pillow that referenced this issue Mar 18, 2016
@wiredfool
Malloc check, python-pillow#1715
0239830
wiredfool added a commit to wiredfool/Pillow that referenced this issue Apr 1, 2016
@wiredfool
Malloc check, python-pillow#1715
60589b5
wiredfool added a commit to wiredfool/Pillow that referenced this issue Apr 1, 2016
@wiredfool
Malloc check, realloc, python-pillow#1715
13b7243
wiredfool added a commit to wiredfool/Pillow that referenced this issue Apr 1, 2016
@wiredfool
Malloc check, python-pillow#1715
1892ee0
wiredfool added a commit to wiredfool/Pillow that referenced this issue Apr 1, 2016
@wiredfool
Malloc check, python-pillow#1715
736b1e4
wiredfool added a commit to wiredfool/Pillow that referenced this issue Apr 1, 2016
@wiredfool
Malloc check, python-pillow#1715
0564fb8
wiredfool added a commit to wiredfool/Pillow that referenced this issue Apr 15, 2016
@wiredfool
Malloc check, python-pillow#1715
fa8f2fd
wiredfool added a commit to wiredfool/Pillow that referenced this issue Apr 15, 2016
@wiredfool
Malloc check, realloc, python-pillow#1715
2e2f983
wiredfool added a commit to wiredfool/Pillow that referenced this issue Apr 19, 2016
@wiredfool
Malloc check, python-pillow#1715
c69977a
wiredfool added a commit to wiredfool/Pillow that referenced this issue Apr 19, 2016
@wiredfool
Malloc check, realloc, python-pillow#1715
12357e4
wiredfool added a commit to wiredfool/Pillow that referenced this issue May 24, 2016
@wiredfool
Malloc check, python-pillow#1715
d2386c2
wiredfool added a commit to wiredfool/Pillow that referenced this issue May 24, 2016
@wiredfool
Malloc check, realloc, python-pillow#1715
93655c6
wiredfool added a commit to wiredfool/Pillow that referenced this issue May 30, 2016
@wiredfool
Malloc check, python-pillow#1715
d3387bc
wiredfool added a commit to wiredfool/Pillow that referenced this issue May 30, 2016
@wiredfool
Malloc check, realloc, python-pillow#1715
f6e624e
wiredfool added a commit to wiredfool/Pillow that referenced this issue Jun 8, 2016
@wiredfool
Malloc check, python-pillow#1715
52d60cd
wiredfool added a commit to wiredfool/Pillow that referenced this issue Jun 8, 2016
@wiredfool
Malloc check, realloc, python-pillow#1715
4b4ef5f
Fahad-Alsaidi pushed a commit to Fahad-Alsaidi/Pillow that referenced this issue Dec 13, 2016
@wiredfool @Fahad-Alsaidi
Malloc check, python-pillow#1715
69b6f6d
Fahad-Alsaidi pushed a commit to Fahad-Alsaidi/Pillow that referenced this issue Dec 13, 2016
@wiredfool @Fahad-Alsaidi
Malloc check, realloc, python-pillow#1715
e5ca16e
Fahad-Alsaidi pushed a commit to Fahad-Alsaidi/Pillow that referenced this issue Dec 13, 2016
@wiredfool @Fahad-Alsaidi
Malloc check, python-pillow#1715
4f5df8a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Preventative Maintenance
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@wiredfool