Allowed text method to pass on multiline_text method specific arguments #1647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
|
Can you add in the new parameters to |
|
Okay, I've added documentation. Let me know if you have any thoughts. I wasn't quite sure whether to specify the additional arguments individually, or to just reference |
| @@ -121,6 +121,7 @@ def test_textsize_equal(self): | |||
| size = draw.textsize(txt, ttf) | |||
| draw.text((10, 10), txt, font=ttf) | |||
| draw.rectangle((10, 10, 10 + size[0], 10 + size[1])) | |||
| del draw | |||
There was a problem hiding this comment.
Why are you adding del draw to all the tests?
There was a problem hiding this comment.
My understanding is that del draw performs a cleanup operation to save memory. It was present on some tests, but not others. If you'd like to go the other way, and remove it in order to reduce unnecessary lines of code in the test suite, just say the word.
There was a problem hiding this comment.
Just wondering, as that seems to be an unrelated change in the test suite.
wiredfool
added a commit
that referenced
this pull request
Feb 1, 2016
Allowed text method to pass on multiline_text method specific arguments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1645