fix bug in TiffImagePlugin. Save and restore pointer to super.load in… #1754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi. Thanks for creating this PR, and joining the community effort to support Pillow. In order to try and avoid regressions in the code at a later point in time, tests are encouraged. Would you be able to add a test to check that this behaves correctly? |
|
Hello. I have added a test. it's failes on master branch, and it's works on my PR |
|
This is a valid problem, but I think the approach should be different. Rather than patching over a questionable design decision, we should fix the underlying issue. |
|
I've created PR #1782 as an alternative fix, cherry-picking the test-related commit from this. |
|
Merged #1782 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a bug in TiffImagePlugin.py. If tiff file has two frames, first with tiff_ccitt compression, and second in packbits compression. _setup method replace self.load with self._load_libtiff if frame has tiff_ccitt, and when you try to load frame with other compression self.load still points to self._load_libtiff, but it need to point to super.load