Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Storage cleanup #2652

Closed
wants to merge 9 commits into from
Closed

Storage cleanup #2652

wants to merge 9 commits into from

Conversation

homm
Copy link
Member

@homm homm commented Aug 5, 2017 •
edited
Loading

This is a small cleanup before the further work on storage module.

  • Tests for different modes for Image.new
  • Fixed memory leak if no available memory for allocating new image
  • Fixed memory leak if xsize > (INT_MAX / 4) - 1
  • Use accurate im->linesize value instead of strlen(mode) approximation

Side effect: removed ImagingNewEpilogue

@homm
no reasons to release GIL for one calloc
79bd456
@homm
check args before allocate memory
7c67911
@homm
FIX memory leak
7da62d5 
ImagingNewEpilogue now is always success
The Imaging object itself is freed through ImagingDelete in case
when memory is not allocated in ImagingNewBlock or ImagingNewArray
@homm
move ImagingNewEpilogue functionality to ImagingNewPrologueSubtype
40676cb 
doublechecked: no im->image or im->image8 or im->image32 access
between ImagingNewPrologue and ImagingNewEpilogue anywhere
@homm
add tests for Image.new modes
da453d0
@homm
destroy image and set MemoryError on overflow check failure
2750d7b
@homm
rename ImagingNewBlock → ImagingAllocateBlock
0e70e6c 
rename ImagingNewArray → ImagingAllocateArray
new utility function with old name ImagingNewBlock
call ImagingNewPrologue outside of ImagingAllocateBlock and ImagingAllocateArray
@homm
use accurate im->linesize instead of strlen(mode) approximation
1ae0890
@homm
fix tests on python 3
0f17356
@homm
Copy link
Member Author

homm commented Aug 6, 2017

Closing in favor of #2654
Changed branch from uploadcare:storage-cleanup to python-pillow:storage-cleanup

@homm homm closed this Aug 6, 2017
@homm homm deleted the storage-cleanup branch August 6, 2017 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@homm