Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated libwebp to 0.6.1 #2880

Merged
merged 2 commits into from
Dec 19, 2017
Merged

Updated libwebp to 0.6.1 #2880

merged 2 commits into from
Dec 19, 2017

Conversation

radarhere
Copy link
Member

@radarhere radarhere commented Dec 6, 2017

A test failed after the update with an average pixel value different of 21.3764, so I increased the threshold to 25.

@@ -119,7 +119,7 @@ def test_write_unsupported_mode_PA(self):
image.getdata()
target = Image.open(file_path).convert("RGBA")

self.assert_image_similar(image, target, 10.0)
self.assert_image_similar(image, target, 25.0)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a pretty big jump for a .0.1 release, are we sure that we're not missing something there?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/webmproject/libwebp/blob/master/NEWS

Here's a copy of the generated file from my local machine using 0.6.1.
transparent

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no idea where those issues actually reside on the web, other than not on github, and not in the repo it's cloned from.

Anyway, it looks like there was a YUV->RGB change in 0.52 that could potentially account for that.

@wiredfool
Copy link
Member

This is now a blocker for the fedora-27 docker tests. python-pillow/docker-images#20 and #2895

@wiredfool wiredfool merged commit c94484e into python-pillow:master Dec 19, 2017
@radarhere radarhere deleted the webp branch December 19, 2017 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants