New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated libwebp to 0.6.1 #2880

Merged
merged 2 commits into from Dec 19, 2017

Conversation

Projects
None yet
2 participants
@radarhere
Member

radarhere commented Dec 6, 2017

A test failed after the update with an average pixel value different of 21.3764, so I increased the threshold to 25.

@@ -119,7 +119,7 @@ def test_write_unsupported_mode_PA(self):
image.getdata()
target = Image.open(file_path).convert("RGBA")
self.assert_image_similar(image, target, 10.0)
self.assert_image_similar(image, target, 25.0)

This comment has been minimized.

@wiredfool

wiredfool Dec 8, 2017

Member

That's a pretty big jump for a .0.1 release, are we sure that we're not missing something there?

@wiredfool

wiredfool Dec 8, 2017

Member

That's a pretty big jump for a .0.1 release, are we sure that we're not missing something there?

This comment has been minimized.

@radarhere

radarhere Dec 8, 2017

Member

https://github.com/webmproject/libwebp/blob/master/NEWS

  • 11/24/2017: version 0.6.1
    This is a binary compatible release.
    • lossless performance and compression improvements + a new 'cruncher' mode
      (-m 6 -q 100)
    • ARM performance improvements with clang (15-20% w/ndk r15c, issue #339)
    • webp-js: emscripten/webassembly based javascript decoder
    • miscellaneous bug & build fixes (issue #329, #332, #343, #353, #360, #361,
      #363)
      Tool updates / additions:
      added webpinfo - prints file format information (issue #330)
      gif2webp - loop behavior modified to match Chrome M63+ (crbug.com/649264);
      '-loop_compatibility' can be used for the old behavior

Here's a copy of the generated file from my local machine using 0.6.1.
transparent

@radarhere

radarhere Dec 8, 2017

Member

https://github.com/webmproject/libwebp/blob/master/NEWS

  • 11/24/2017: version 0.6.1
    This is a binary compatible release.
    • lossless performance and compression improvements + a new 'cruncher' mode
      (-m 6 -q 100)
    • ARM performance improvements with clang (15-20% w/ndk r15c, issue #339)
    • webp-js: emscripten/webassembly based javascript decoder
    • miscellaneous bug & build fixes (issue #329, #332, #343, #353, #360, #361,
      #363)
      Tool updates / additions:
      added webpinfo - prints file format information (issue #330)
      gif2webp - loop behavior modified to match Chrome M63+ (crbug.com/649264);
      '-loop_compatibility' can be used for the old behavior

Here's a copy of the generated file from my local machine using 0.6.1.
transparent

This comment has been minimized.

@wiredfool

wiredfool Dec 19, 2017

Member

I have no idea where those issues actually reside on the web, other than not on github, and not in the repo it's cloned from.

Anyway, it looks like there was a YUV->RGB change in 0.52 that could potentially account for that.

@wiredfool

wiredfool Dec 19, 2017

Member

I have no idea where those issues actually reside on the web, other than not on github, and not in the repo it's cloned from.

Anyway, it looks like there was a YUV->RGB change in 0.52 that could potentially account for that.

@wiredfool

This comment has been minimized.

Show comment
Hide comment
@wiredfool

wiredfool Dec 19, 2017

Member

This is now a blocker for the fedora-27 docker tests. python-pillow/docker-images#20 and #2895

Member

wiredfool commented Dec 19, 2017

This is now a blocker for the fedora-27 docker tests. python-pillow/docker-images#20 and #2895

@wiredfool wiredfool merged commit c94484e into python-pillow:master Dec 19, 2017

5 checks passed

codecov/patch Coverage not affected when comparing 6eb534b...97dba99
Details
codecov/project 83.38% remains the same compared to 6eb534b
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 83.381%
Details

@radarhere radarhere deleted the radarhere:webp branch Dec 19, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment