Improve ImageGrab.grabclipboard() on Windows #4615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
radarhere
reviewed
May 28, 2020
Co-authored-by: Andrew Murray <3112309+radarhere@users.noreply.github.com>
radarhere
reviewed
Jun 14, 2020
| from . import BmpImagePlugin | ||
|
|
||
| return BmpImagePlugin.DibImageFile(data) | ||
| return None |
There was a problem hiding this comment.
This might just be a curious question - why change this from return data to return None?
There was a problem hiding this comment.
It should be dead code in both cases, I just think None is a safer fallback then returning undefined data. If I had to guess, the original return was written in anticipation of implementing CF_HDROP support in C code, but I found it easier in Python.
|
Thanks! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Helps #4611
Adds support for the following clipboard formats on Windows in addition to the already supported
CF_DIB:CF_DIBV5'PNG'used by e.g. MS Word 2016 and Paint.NET,CF_HDROPused by most browsers (except Chrome), file explorers, etc.Support for
CF_HDROPwas already hinted at in the documentation, but there was merely a FIXME in place of the code.Used format is selected out of available formats based on the priority specified by the clipboard owner.
While I could see the argument that CF_HDROP is more complicated and should therefore only be a fallback, based on my testing, it is almost always the preferred format, and preserves the original image data (e.g. transparency, tags, ...), unlike bitmaps.