Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create PEP508 compliant dependency string for directory and file dependencies #1796

Merged
merged 2 commits into from Jan 10, 2020

Conversation

@finswimmer
Copy link
Member

finswimmer commented Dec 27, 2019

With this PR directory and file dependencies return PEP508 compliant dependency strings.

Until now for these type of dependencies only the package name was returned.

Depending on how the discussion here ends, this might resolve #1689 as well.

Pull Request Check List

This is just a reminder about the most common mistakes. Please make sure that you tick all appropriate boxes. But please read our contribution guide at least once, it will save you unnecessary review cycles!

  • Added tests for changed code.
  • Updated documentation for changed code.
…dependency string for directory and file dependencies
@finswimmer finswimmer requested a review from python-poetry/core Dec 27, 2019
@finswimmer finswimmer added the Bug label Dec 27, 2019
Copy link
Member

sdispater left a comment

Thanks! LGTM 👍

@sdispater sdispater merged commit 10e471a into python-poetry:master Jan 10, 2020
16 checks passed
16 checks passed
Linting
Details
Linux (2.7)
Details
Linux (3.5)
Details
Linux (3.6)
Details
Linux (3.7)
Details
Linux (3.8)
Details
MacOS (2.7)
Details
MacOS (3.5)
Details
MacOS (3.6)
Details
MacOS (3.7)
Details
MacOS (3.8)
Details
Windows (2.7)
Details
Windows (3.5)
Details
Windows (3.6)
Details
Windows (3.7)
Details
Windows (3.8)
Details
sdispater added a commit that referenced this pull request Jan 10, 2020
…ile dependencies (#1796)"

This reverts commit 10e471a.
sdispater added a commit that referenced this pull request Jan 10, 2020
…ile dependencies (#1796)" (#1865)

This reverts commit 10e471a.
@sdispater sdispater mentioned this pull request Jan 10, 2020
0 of 2 tasks complete
@StephenBrown2 StephenBrown2 mentioned this pull request Jan 10, 2020
5 of 5 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.