Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create PEP508 compliant dependency string for directory and file dependencies #1796

Merged
merged 2 commits into from Jan 10, 2020

Conversation

finswimmer
Copy link
Member

@finswimmer finswimmer commented Dec 27, 2019

With this PR directory and file dependencies return PEP508 compliant dependency strings.

Until now for these type of dependencies only the package name was returned.

Depending on how the discussion here ends, this might resolve #1689 as well.

Pull Request Check List

This is just a reminder about the most common mistakes. Please make sure that you tick all appropriate boxes. But please read our contribution guide at least once, it will save you unnecessary review cycles!

  • Added tests for changed code.
  • Updated documentation for changed code.

…dependency string for directory and file dependencies
@finswimmer finswimmer requested a review from Dec 27, 2019
@finswimmer finswimmer added the Bug label Dec 27, 2019
Copy link
Member

@sdispater sdispater left a comment

Thanks! LGTM 👍

@sdispater sdispater merged commit 10e471a into python-poetry:master Jan 10, 2020
16 checks passed
sdispater added a commit that referenced this issue Jan 10, 2020
sdispater added a commit that referenced this issue Jan 10, 2020
@sdispater sdispater mentioned this pull request Jan 10, 2020
2 tasks
@finswimmer finswimmer deleted the pep508-dependencies branch Apr 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants