Skip to content

Use relative path for api.specs_url. #214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 2, 2020
Merged

Use relative path for api.specs_url. #214

merged 1 commit into from
Sep 2, 2020

Conversation

jslay88
Copy link
Contributor

@jslay88 jslay88 commented Sep 2, 2020

This resolves any issues with mixed content when running behind an HTTPS reverse proxy.
There is no valid use case for using absolute over relative here, and only causes additional issues.

Resolves #188

This resolves any issues with mixed content when running behind an HTTPS reverse proxy.
There is no valid use case for using absolute over relative here, and only causes additional issues.

Resolves #188
@codecov
Copy link

codecov bot commented Sep 2, 2020

Codecov Report

Merging #214 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #214   +/-   ##
=======================================
  Coverage   96.92%   96.92%           
=======================================
  Files          19       19           
  Lines        2697     2697           
=======================================
  Hits         2614     2614           
  Misses         83       83           
Impacted Files Coverage Δ
flask_restx/api.py 97.13% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 85706be...fa96ffe. Read the comment docs.

@ziirish
Copy link
Contributor

ziirish commented Sep 2, 2020

Thanks for your contribution!

@ziirish ziirish merged commit 858ac78 into python-restx:master Sep 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HTTPS Mixed Content for swagger.json with gunicorn
2 participants