Switch to pytest #788
Merged
Switch to pytest #788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Still just testing stuff :)
Might as well have our tests look good
Eldinnie
approved these changes
Aug 11, 2017
Merged
tsnoam
requested changes
Aug 11, 2017
| [report] | ||
| omit = | ||
| tests/ | ||
| telegram/vendor/* |
There was a problem hiding this comment.
removing this file is in order to switch to codecov?
There was a problem hiding this comment.
Not quite, it's moved to setup.cfg so it's together with the pytest config
| - if [[ $TRAVIS_PYTHON_VERSION != 'pypy'* ]]; then pip install ujson; fi | ||
|
|
||
| script: | ||
| - python travis.py | ||
| - pytest -v --cov=telegram | ||
|
|
||
| after_success: | ||
| coveralls |
There was a problem hiding this comment.
aren't we switching out from coveralls?
There was a problem hiding this comment.
We are, but that's not in this PR
pytest_migrate.py
Outdated
| new_class = re.sub(r'self.json_dict', r'json_dict', new_class) | ||
|
|
||
| new_text += new_class | ||
| new_file = Path('pytests/' + sys.argv[1]).open('w', encoding='UTF-8').write(new_text) |
There was a problem hiding this comment.
Do we really need this file in git?
There was a problem hiding this comment.
Whoops, no we do indeed not
|
|
||
| ''' Commented out, because it would cause "Too Many Requests (429)" errors. |
There was a problem hiding this comment.
Should we have this comment copied to the new tests as well?
There was a problem hiding this comment.
It's marked as xfail if it raises RetryError or if on pypy (where it's strangely more unstable)
tsnoam
approved these changes
Aug 11, 2017
Merged
This was referenced Mar 2, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a joint PR between me and @Eldinnie.
This completes the move to the pytest testing framework. Tests are now run using (after installing
requirements-dev.txt:# -v means verbose $ pytest -vWith this our coverage once again reaches > 90% and with #778, it should increase even further (this is due to removing de_json tests from the objects mentioned in that issue, since it seemed stupid to port tests that were just gonna get removed)
Other changes
This PR also includes some other changes related to tests without actually being tests
.coveragerc) tosetup.cfgfor two reasons:pragma: no covercomment worked, but those lines should indeed be excluded from coverage)GameandMessagenow default tolist()instead ofNonesince they are indeed lists no matter whateffective_attachment"Because a few of the possible attachments will evaluate to an empty list if not present (photo for instance). This way it covers those too." - @Eldinnie.Opening a new PR instead of piggy bagging on #757, since it's gonna be squashed and @Eldinnie didn't care for the Github credit (on the projects collaborators view and on his profile), the other alternative was a manually squash a lot of stuff which wouldn't just be quite ugly but also time consuming