Skip to content

Conversation

florimondmanca
Copy link
Contributor

Adds support for renaming type hints to async classes that use a forward reference, i.e. xyz: "AsyncXYZ".

(Support for renaming when the type hint is a regular name, i.e. xyz: AsyncXYZ, was already added via #49.)

@codecov
Copy link

codecov bot commented Jan 4, 2020

Codecov Report

Merging #53 into master will increase coverage by 0.22%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master      #53      +/-   ##
==========================================
+ Coverage   96.55%   96.77%   +0.22%     
==========================================
  Files           4        4              
  Lines         174      186      +12     
  Branches       44       46       +2     
==========================================
+ Hits          168      180      +12     
  Misses          2        2              
  Partials        4        4
Impacted Files Coverage Δ
src/unasync/__init__.py 96.73% <100%> (+0.22%) ⬆️
unasync/__init__.py 96.73% <0%> (+0.22%) ⬆️

Copy link
Contributor

@sethmlarson sethmlarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! Looks good to me.

@sethmlarson sethmlarson merged commit 2c2c9b7 into python-trio:master Jan 5, 2020
@trio-bot
Copy link

trio-bot bot commented Jan 5, 2020

Hey @florimondmanca, it looks like that was the first time we merged one of your PRs! Thanks so much! 🎉 🎂

If you want to keep contributing, we'd love to have you. So, I just sent you an invitation to join the python-trio organization on Github! If you accept, then here's what will happen:

  • Github will automatically subscribe you to notifications on all our repositories. (But you can unsubscribe again if you don't want the spam.)

  • You'll be able to help us manage issues (add labels, close them, etc.)

  • You'll be able to review and merge other people's pull requests

  • You'll get a [member] badge next to your name when participating in the Trio repos, and you'll have the option of adding your name to our member's page and putting our icon on your Github profile (details)

If you want to read more, here's the relevant section in our contributing guide.

Alternatively, you're free to decline or ignore the invitation. You'll still be able to contribute as much or as little as you like, and I won't hassle you about joining again. But if you ever change your mind, just let us know and we'll send another invitation. We'd love to have you, but more importantly we want you to do whatever's best for you.

If you have any questions, well... I am just a humble Python script, so I probably can't help. But please do post a comment here, or in our chat, or on our forum, whatever's easiest, and someone will help you out!

@florimondmanca florimondmanca deleted the typing-forward-refs branch January 5, 2020 01:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants