Fix failed samples calculation

Author: pablogsal

Lib/profiling/sampling/collector.py

@@ -18,6 +18,10 @@ class Collector(ABC):
     def collect(self, stack_frames):
         """Collect profiling data from stack frames."""
 
+    def collect_failed_sample(self, exeption):
+        """Collect data about a failed sample attempt."""
+        pass
+
     @abstractmethod
     def export(self, filename):
         """Export collected data to a file."""

Lib/profiling/sampling/live_collector.py

@@ -433,7 +433,7 @@ def draw_efficiency_bar(self, line, width):
         self.add_str(line, col, "Efficiency:", curses.A_BOLD)
         col += 11
 
-        label = f" {success_pct:>5.1f}% good, {failed_pct:>4.1f}% failed"
+        label = f" {success_pct:>5.2f}% good, {failed_pct:>4.2f}% failed"
         available_width = width - col - len(label) - 3
 
         if available_width >= MIN_BAR_WIDTH:
@@ -1324,6 +1324,9 @@ def _process_frames(self, frames):
         )
         self.result[top_location]["direct_calls"] += 1
 
+    def collect_failed_sample(self, exeption):
+        self._failed_samples += 1
+
     def collect(self, stack_frames):
         """Collect and display profiling data."""
         if self.start_time is None:
@@ -1340,11 +1343,7 @@ def collect(self, stack_frames):
             if frames:
                 got_frames = True
 
-        if got_frames:
-            self._successful_samples += 1
-        else:
-            self._failed_samples += 1
-
+        self._successful_samples += 1
         self.total_samples += 1
 
         # Handle input on every sample for instant responsiveness

Lib/profiling/sampling/sample.py

@@ -199,7 +199,8 @@ def sample(self, collector, duration_sec=10):
                 except ProcessLookupError:
                     duration_sec = current_time - start_time
                     break
-                except (RuntimeError, UnicodeDecodeError, MemoryError, OSError):
+                except (RuntimeError, UnicodeDecodeError, MemoryError, OSError) as e:
+                    collector.collect_failed_sample(e)
                     errors += 1
                 except Exception as e:
                     if not self._is_process_running():