Skip to content

gh-110319: Assert type_version != 0 before using it #112226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gvanrossum merged 2 commits into from
Nov 18, 2023
Merged

gh-110319: Assert type_version != 0 before using it #112226

gvanrossum merged 2 commits into from
Nov 18, 2023

Conversation

@gvanrossum
Copy link
Member

@gvanrossum gvanrossum commented Nov 18, 2023 •
edited by bedevere-app bot
Loading

  • Ensure that assert(type_version != 0); always comes before using type_version

Also:

  • In cases_generator, rename -v to from --verbose to --viable

@bedevere-app bedevere-app bot mentioned this pull request Nov 18, 2023
Closed
@gvanrossum gvanrossum merged commit eb3c94e into python:main Nov 18, 2023
@gvanrossum gvanrossum deleted the more-tweaks branch November 18, 2023 04:58
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
@gvanrossum @aisk
pythongh-110319: Assert type_version != 0 before using it (python#112226
368520f 
)

- Ensure that `assert(type_version != 0);` always comes *before* using `type_version`

Also:
- In cases_generator, rename `-v` to from `--verbose` to `--viable`
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@gvanrossum @Glyphack
pythongh-110319: Assert type_version != 0 before using it (python#112226
b409198 
)

- Ensure that `assert(type_version != 0);` always comes *before* using `type_version`

Also:
- In cases_generator, rename `-v` to from `--verbose` to `--viable`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@gvanrossum