[3.12] Correct documentation for AF_PACKET (GH-112339) #112477
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Protocol in the address tuple should *not* be in the network-byte-order, because it is converted internally[1]. [1] https://github.com/python/cpython/blob/89ddea4886942b0c27a778a0ad3f0d5ac5f518f0/Modules/socketmodule.cGH-L2144 network byte order doesn't make sense for a python level int anyways. It's a fixed size C serialization concept. (cherry picked from commit 562d714) Co-authored-by: Eugene Toder <eltoder@users.noreply.github.com>
bedevere-app
bot
added
awaiting review
docs
gpshead
added a commit
to gpshead/cpython
that referenced
this pull request
Nov 27, 2023
Network byte order is not involved in the `int` on the Python side. That happens under the hood. Correctly use the term addresses instead of packets.
gpshead
approved these changes
Nov 27, 2023
gpshead
added a commit
that referenced
this pull request
Nov 27, 2023
Backport PR #112477: correct socket AF_PACKET docs Network byte order is not involved in the `int` on the Python side. That happens under the hood. Correctly use the term addresses instead of packets.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Protocol in the address tuple should not be in the network-byte-order, because it is converted internally[1].
[1] https://github.com/python/cpython/blob/89ddea4886942b0c27a778a0ad3f0d5ac5f518f0/Modules/socketmodule.cGH-L2144
network byte order doesn't make sense for a python level int anyways. It's a fixed size C serialization concept.
(cherry picked from commit 562d714)
Co-authored-by: Eugene Toder eltoder@users.noreply.github.com
📚 Documentation preview 📚: https://cpython-previews--112477.org.readthedocs.build/