-
-
Notifications
You must be signed in to change notification settings - Fork 33k
Closed
Labels
type-bugAn unexpected behavior, bug, or errorAn unexpected behavior, bug, or error
Description
Feature or enhancement
Proposal:
When writing C/C++ extensions accoding to the doc, there would be problem if the Setup.local
does not have an ending line break:
bad word spammodule.o*doconfig* in spammodule.o*doconfig*
make: *** [Makefile] Error 1
The reason is that, the *doconfig*
in the following location may be concatenated with the previous $i
, thus forming an invalid line:
Line 95 in 2982bdb
*) echo '*doconfig*'; cat "$i";; |
So far the doc does not seem to explicitly mention adding line break. I think this can be fixed by checking for ending line break after the
cat
, and add one if there is not.
Has this already been discussed elsewhere?
No response given
Links to previous discussion of this feature:
No response
Linked PRs
Metadata
Metadata
Assignees
Labels
type-bugAn unexpected behavior, bug, or errorAn unexpected behavior, bug, or error