gh-116943: makesetup to allow missing ending line break for Setup files

[yghjn]

• Issue: makesetup to allow missing ending line break for Setup files #116943

[ghost]

All commit authors signed the Contributor License Agreement.

[bedevere-app]

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

[vstinner]

cc @erlend-aasland

[python-cla-bot]

The following commit authors need to sign the Contributor License Agreement:

• 126801235+yghjn@users.noreply.github.com

[erlend-aasland]

This is not a problem for most folks; we've had this bash code since 1994. IOW, most people have text editors that add new lines. Either we just update the docs to say that Setup.local must contain EOL, or we simply add an implicit newline in the loop:

diff --git a/Modules/makesetup b/Modules/makesetup
index f6cf695b457..104c824b846 100755
--- a/Modules/makesetup
+++ b/Modules/makesetup
@@ -90,6 +90,7 @@ NL='\
 # Main loop
 for i in ${*-Setup}
 do
+       echo ''  # Add a linebreak so we don't choke on files missing EOL.
        case $i in
        -n)     echo '*noobjects*';;
        *)      echo '*doconfig*'; cat "$i";;

[erlend-aasland]

Closing in favour of #139100, and also since the CLA is not signed.