gh-140029: avoid impact of system proxies on urllib test suite by mocking relevant functions #140144
+19
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
|
it fix the problem in my side cc @aisk can you help to check since it a proxy problem~?❤️ |
aisk
reviewed
Oct 16, 2025
…king relevant functions Signed-off-by: Frost Ming <me@frostming.com>
frostming
force-pushed
the
fix/urllib-test-proxy
branch
from
752899d to
6526aa5
Compare
Signed-off-by: Frost Ming <me@frostming.com>
frostming
force-pushed
the
fix/urllib-test-proxy
branch
from
6526aa5 to
c3ecb3b
Compare
aisk
approved these changes
Oct 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Frost Ming me@frostming.com
Skip news