gh-137568: Ignore startup file in test_dumb_terminal_exits_cleanly
#140295
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZeroIntensity
added
skip news
needs backport to 3.13
ZeroIntensity
approved these changes
Oct 24, 2025
Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
|
Thanks @bswck for the PR, and @ZeroIntensity for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Oct 26, 2025
…anly` (pythonGH-140295) (cherry picked from commit 06c7794) Co-authored-by: Bartosz Sławecki <bartosz@ilikepython.com>
|
Sorry, @bswck and @ZeroIntensity, I could not cleanly backport this to |
|
GH-140628 is a backport of this pull request to the 3.14 branch. |
|
@bswck Could you do the 3.13 backport? |
bswck
added a commit
to bswck/cpython
that referenced
this pull request
Oct 26, 2025
…its_cleanly` (pythonGH-140295) (cherry picked from commit 06c7794) Co-authored-by: Bartosz Sławecki <bartosz@ilikepython.com>
|
GH-140632 is a backport of this pull request to the 3.13 branch. |
ZeroIntensity
pushed a commit
that referenced
this pull request
Oct 26, 2025
ZeroIntensity
pushed a commit
that referenced
this pull request
Oct 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test examines tracebacks, but one can occur in a failing startup file and the test shouldn't fail just because of that.
CC @ZeroIntensity (mentorship):
skip newshere. We'll want to backport as well -- let's add3.13and3.14to the issue.test_pyrepl.test_dumb_terminal_exits_cleanlyfails under Fish when run in VS Code's terminal #137568