-
-
Notifications
You must be signed in to change notification settings - Fork 33.4k
gh-131527: Stackref debug borrow checker #140599
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-131527: Stackref debug borrow checker #140599
Conversation
|
It works fine and generally follows the sketch in the issue. There are 17 failed tests with this PR in Compare with Here There's no real problem here but we can rewrite it a little to prevent this error and make code related to |
mpage
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Just some minor inline comments/suggestions. Feel free to push back if you don't agree.
mpage
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - thanks!
Uh oh!
There was an error while loading. Please reload this page.