-
-
Notifications
You must be signed in to change notification settings - Fork 33.4k
gh-140942: Add MIME type for .cjs extension #140937
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
1 similar comment
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
StanFromIreland
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not think this change is correct, it is not officially registered with IANA as required.
Thanks for the review, @StanFromIreland! I updated this PR to add the extension to |
|
IANA says https://www.iana.org/assignments/media-types/application/node
And this makes no mention of the MIME type. |
|
Thanks for the update. And because this is actually registered with IANA, we can put it in the regular list. Please also don't force push in this repo, it makes it a bit harder to review changes. We squash merge anyway at the end. |
|
@hugovk That's a good point about force-pushing. Thank you for your help! |
hugovk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add to the first in the mimetypes list at https://docs.python.org/3.15/whatsnew/3.15.html#mimetypes
Misc/NEWS.d/next/Core_and_Builtins/2025-11-04-12-18-06.gh-issue-140942.GYns6n.rst
Outdated
Show resolved
Hide resolved
Adds .cjs mimetype of `text/javascript` for CommonJS modules to common_types. See here for more information: https://nodejs.org/api/modules.html#enabling
…e-140942.GYns6n.rst Add changes to news entry from code review Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
|
Reminder about these things :)
|
|
@hugovk Oh, weird, I think my local repo had an issue because I checked out with a depth of 1 and |
hugovk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Updates MIME types with
.cjstype ofapplication/nodefor CommonJS modules. See here for more information: https://www.iana.org/assignments/media-types/application/nodeFixes #140942