rlcompleter does not expand on [ ]

[schiekjd]

BPO	547176
Nosy	@mwhudson, @brettcannon, @birkenfeld
Files	rlcompleter.diff: diff for fix on v1.11 from CVS

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = 'https://github.com/mwhudson'
closed_at = <Date 2005-02-23.18:56:04.000>
created_at = <Date 2002-04-22.17:39:43.000>
labels = []
title = 'rlcompleter does not expand on [ ]'
updated_at = <Date 2005-02-23.18:56:04.000>
user = 'https://bugs.python.org/schiekjd'

bugs.python.org fields:

activity = <Date 2005-02-23.18:56:04.000>
actor = 'mwh'
assignee = 'mwh'
closed = True
closed_date = None
closer = None
components = ['None']
creation = <Date 2002-04-22.17:39:43.000>
creator = 'schiekjd'
dependencies = []
files = ['4185']
hgrepos = []
issue_num = 547176
keywords = ['patch']
message_count = 5.0
messages = ['39679', '39680', '39681', '39682', '39683']
nosy_count = 5.0
nosy_names = ['mwh', 'brett.cannon', 'georg.brandl', 'mbrierst', 'schiekjd']
pr_nums = []
priority = 'normal'
resolution = 'wont fix'
stage = None
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue547176'
versions = []

[schiekjd]

A thread on comp.lang.python details the problem:

http://groups.google.com/groups?
hl=en&threadm=b5ddd682.0204180902.2866a9c0%
40posting.google.com&rnum=1&prev=/groups%3Fhl%3Den%
26selm%3Db5ddd682.0204180902.2866a9c0%
2540posting.google.com

rlcompleter.py does not expand correctly on something 
like:
>>> sim[0].<tab>
since
  m = re.match(r"(\w+(\.\w+)*)\.(\w*)", text)
does not allow for brackets in the match.

I propose:
m = re.match(r"([\w\[\]]+(\.[\w\[\]]+))\.(\w)",
text)

to fix this on line 127 in cvs version 1.11

[mbrierst]

Logged In: YES
user_id=670441

This isn't really a bug, as (at least currently) this behavior is mentioned in the documentation for rlcompleter (at least it's in the docstring).

The reason a[0].<tab> isn't completed is that we want to avoid executing arbitrary code. The current completion mechanism is already a bit dangerous as an object's getattr could be called to execute code with unknown side effects while completing. It just seems to dangerous to allow indexing, as lots of objects use this for their own purposes.

If this behavior is determined desirable despite the danger, someone with commit privileges should say so, and then someone can submit a patch (I could do it).
Probably this bug should just be closed.

[brettcannon]

Logged In: YES
user_id=357491

Making this a patch since one is included.

[birkenfeld]

Logged In: YES
user_id=1188172

As the other commentors point out, this easily leads to
execution of arbitrary code via __getitem__, which is IMHO a
too big side effect of completing (though IPython does
this). Recommend reject.

[mwhudson]

Logged In: YES
user_id=6656

Closing. If you want a richer completion environment you can use IPython
or rlcompleter2.