imaplib: parsing INTERNALDATE

[hinsen]

BPO	698706
Nosy	@birkenfeld, @facundobatista

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2005-11-26.16:32:59.000>
created_at = <Date 2003-03-06.13:45:38.000>
labels = ['library']
title = 'imaplib: parsing INTERNALDATE'
updated_at = <Date 2005-11-26.16:32:59.000>
user = 'https://bugs.python.org/hinsen'

bugs.python.org fields:

activity = <Date 2005-11-26.16:32:59.000>
actor = 'georg.brandl'
assignee = 'pierslauder'
closed = True
closed_date = None
closer = None
components = ['Library (Lib)']
creation = <Date 2003-03-06.13:45:38.000>
creator = 'hinsen'
dependencies = []
files = []
hgrepos = []
issue_num = 698706
keywords = []
message_count = 4.0
messages = ['14997', '14998', '14999', '15000']
nosy_count = 5.0
nosy_names = ['georg.brandl', 'facundobatista', 'hinsen', 'pierslauder', 'anadelonbrin']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = None
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue698706'
versions = ['Python 2.4']

[hinsen]

The regular expression InternalDate in imaplib does not
match dates in which the day number is two-digit with a
leading zero.

From a cursory glance at the IMAP definition, this is a
legal format, and there is at least one IMAP server that
uses it (courier-imap).

The attached patch is for Python 2.2.2, but the problem still
exists in 2.3a2.

[anadelonbrin]

Logged In: YES
user_id=552329

This is correct, RFC 2060 allows for the date to be
"2digit", where digit includes 0. There is no attached
patch, but I can't attach to this tracker, so I'm putting it
here in the comment (it's a one character change). This
still exists in 2004-04-23 anon cvs.

*** imaplib.py Fri Apr 23 13:40:32 2004
--- imaplib-fixed.py Fri Apr 23 13:42:31 2004

---

*** 79,85 ****
Continuation = re.compile(r'\+( (?P<data>.*))?')
Flags = re.compile(r'.*FLAGS \((?P<flags>[^\\)]*)\)')
InternalDate = re.compile(r'.*INTERNALDATE "'
! r'(?P<day>[
123][0-9])-(?P<mon>[A-Z][a-z][a-z])-(?P<year>[0-9][0-9][0-
9][0-9])'
r'
(?P<hour>[0-9][0-9]):(?P<min>[0-9][0-9]):(?P<sec>[0-9][0-9])'
r'
(?P<zonen>[-+])(?P<zoneh>[0-9][0-9])(?P<zonem>[0-9][0-9])'
r'"')
--- 79,85 ----

  Continuation = re.compile(r'\+( (?P<data>.*))?')
  Flags = re.compile(r'.*FLAGS \((?P<flags>[^\)]*)\)')
  InternalDate = re.compile(r'.*INTERNALDATE "'
!         r'(?P<day>[
0123][0-9])-(?P<mon>[A-Z][a-z][a-z])-(?P<year>[0-9][0-9][0
-9][0-9])'
          r'
(?P<hour>[0-9][0-9]):(?P<min>[0-9][0-9]):(?P<sec>[0-9][0-9])'
          r'
(?P<zonen>[-+])(?P<zoneh>[0-9][0-9])(?P<zonem>[0-9][0-9])'
          r'"')

[facundobatista]

Logged In: YES
user_id=752496

This patch is not yet applied in CVS.

Piers, I assign this to you because you know the module, but
the patch is pretty simple, it's just adding a 0 to a part
of the InternalDate's re:

From: (?P<day>[ 123]
To: (?P<day>[ 0123]

[birkenfeld]

Logged In: YES
user_id=1188172

Already corrected in the 2.5 branch. Corrected in the 2.4
branch in revision 41547.