compiler.pycodegen causes crashes when compiling 'with'

[kirat]

BPO	1638243
Nosy	@birkenfeld
Files	diffs.txt: compiler patch for with code generation

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = 'https://github.com/birkenfeld'
closed_at = <Date 2007-01-27.17:43:16.000>
created_at = <Date 2007-01-18.03:52:36.000>
labels = ['interpreter-core']
title = "compiler.pycodegen causes crashes when compiling 'with'"
updated_at = <Date 2007-01-27.17:43:16.000>
user = 'https://bugs.python.org/kirat'

bugs.python.org fields:

activity = <Date 2007-01-27.17:43:16.000>
actor = 'georg.brandl'
assignee = 'georg.brandl'
closed = True
closed_date = None
closer = None
components = ['Interpreter Core']
creation = <Date 2007-01-18.03:52:36.000>
creator = 'kirat'
dependencies = []
files = ['7729']
hgrepos = []
issue_num = 1638243
keywords = ['patch']
message_count = 2.0
messages = ['51765', '51766']
nosy_count = 2.0
nosy_names = ['georg.brandl', 'kirat']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = None
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue1638243'
versions = ['Python 2.5']

[kirat]

The compiler package in the python library is missing a LOAD/DELETE just before the WITH_CLEANUP instruction.

Also transformer isn't creating the with_var as an assignment.

So the following little code snippet will crash if you compile and run it with compiler.compile()

class TrivialContext:
    def __enter__(self): return self
    def __exit__(self,*exc_info): pass

def f():
    with TrivialContext() as tc:
        return 1
f()

The fix is just a few lines. I'm enclosing a patch against the python 2.5 source.

I've also added the above as a test case to the test_compiler.py file.

regards,
-Kirat

[birkenfeld]

Thanks for the patch, this is fixed now in rev. 53575, 53576 (2.5).