-
-
Notifications
You must be signed in to change notification settings - Fork 31.8k
Use computed gotos by default #53449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Now that the option has probably been extensively tested, it would be nice to enable computed gotos by default on systems that support them. |
Antoine Pitrou wrote:
I doubt that it has been tested enough, but enabling it Have you tried testing this using the buildbots ? |
Marc-Andre Lemburg wrote:
Here's a compiler/platform combination where it should not be used gcc 4.4.2 on AMD processors ... The fix will go into gcc 4.5, the report doesn't say whether it was |
So? Compilers have all kinds of optimization bugs, it's not our job to (well, you can of course maintain such a matrix if you want) For the record, I had an Athlon 64 machine until very recently, used it |
Antoine Pitrou wrote:
No, but we do need to make sure that the casual user does not An expert user can always use the right compiler... but then an gcc 4.4.2 is not exactly an old version of gcc. The perspective
Perhaps someone can report whether this affects Ubuntu 10.4 LTS ?! |
The point is that we cannot make it sure. There is nothing specific (also, I'll point out that it's not demonstrated that the problem above |
I think there is no risk here. The casual Python user on an AMD64 system |
Martin v. Löwis wrote:
I'd be fine with enabling the switch on those platforms as well, If the problem is really only with the code snippet listed in the |
I've committed a patch in r83986. I will watch the buildbots and close if everything's fine. |
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
bugs.python.org fields:
The text was updated successfully, but these errors were encountered: