Remove last traces of -Q / sys.flags.division_warning / Py_DivisionWarningFlag

[merwok]

BPO	10998
Nosy	@birkenfeld, @rhettinger, @benjaminp, @merwok
Files	division_warning.diff

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = 'https://github.com/merwok'
closed_at = <Date 2011-03-26.01:11:54.690>
created_at = <Date 2011-01-24.19:25:49.768>
labels = ['interpreter-core', 'type-bug']
title = 'Remove last traces of -Q / sys.flags.division_warning / Py_DivisionWarningFlag'
updated_at = <Date 2011-04-27.14:37:37.139>
user = 'https://github.com/merwok'

bugs.python.org fields:

activity = <Date 2011-04-27.14:37:37.139>
actor = 'python-dev'
assignee = 'eric.araujo'
closed = True
closed_date = <Date 2011-03-26.01:11:54.690>
closer = 'eric.araujo'
components = ['Interpreter Core']
creation = <Date 2011-01-24.19:25:49.768>
creator = 'eric.araujo'
dependencies = []
files = ['20505']
hgrepos = []
issue_num = 10998
keywords = ['patch', 'needs review']
message_count = 9.0
messages = ['126943', '126944', '126951', '126961', '126992', '132196', '132199', '132202', '134569']
nosy_count = 5.0
nosy_names = ['georg.brandl', 'rhettinger', 'benjamin.peterson', 'eric.araujo', 'python-dev']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue10998'
versions = ['Python 3.3']

[merwok]

The -Q command-line option has been removed in Python 3 but there are some leftovers. Attached patch removes them; tests pass; please review.

I think 3.1 should be fixed too, since no sane program should use those leftovers.

I removed the now-pointless tests in test_cmd_line. They were not failing; this may be a bug in verify_valid_flag, out of scope for this report.

While I was editing the table used to document sys.flags, I added some link-generating markup (to the respective option doc) and made the table markup easier to read and edit. I can make those changes in another commit if you prefer it.

[birkenfeld]

This would have been good for 3.2, but it is an API change...

[rhettinger]

I'm in mildly in favor of getting this done before the next release candidate. It seems like a desirable clean-up that would better be done sooner than later.

[merwok]

My argument that this change should have no impact so it’s safe to commit also works the other way: there is no pressure to make an exception to the process and commit this after rc1. 3.1 and 3.2 will have the bug, 3.3 won’t.

[birkenfeld]

You can even argue it's a bug fix for 3.2.1, but I'd rather keep the list of changes in the rc small.

[python-dev]

New changeset 0d2ef718ae67 by Éric Araujo in branch '3.1':
Tweaks to sys.flags description table.
http://hg.python.org/cpython/rev/0d2ef718ae67

New changeset c19752ea037f by Éric Araujo in branch 'default':
Remove traces of division_warning left over from Python 2 (bpo-10998)
http://hg.python.org/cpython/rev/c19752ea037f

[merwok]

Given your approval of the idea and lack of code comments, I committed the patch for 3.3 without requesting more review.

[python-dev]

New changeset 814599728ac0 by Éric Araujo in branch '2.7':
Tweaks to sys.flags description table.
http://hg.python.org/cpython/rev/814599728ac0

[python-dev]

New changeset f9e2b2b17e58 by Éric Araujo in branch 'default':
Add versionchanged for c19752ea037f (bpo-10998)
http://hg.python.org/cpython/rev/f9e2b2b17e58