-
-
Notifications
You must be signed in to change notification settings - Fork 31.7k
Remove last traces of -Q / sys.flags.division_warning / Py_DivisionWarningFlag #55207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
The -Q command-line option has been removed in Python 3 but there are some leftovers. Attached patch removes them; tests pass; please review. I think 3.1 should be fixed too, since no sane program should use those leftovers. I removed the now-pointless tests in test_cmd_line. They were not failing; this may be a bug in verify_valid_flag, out of scope for this report. While I was editing the table used to document sys.flags, I added some link-generating markup (to the respective option doc) and made the table markup easier to read and edit. I can make those changes in another commit if you prefer it. |
This would have been good for 3.2, but it is an API change... |
I'm in mildly in favor of getting this done before the next release candidate. It seems like a desirable clean-up that would better be done sooner than later. |
My argument that this change should have no impact so it’s safe to commit also works the other way: there is no pressure to make an exception to the process and commit this after rc1. 3.1 and 3.2 will have the bug, 3.3 won’t. |
You can even argue it's a bug fix for 3.2.1, but I'd rather keep the list of changes in the rc small. |
New changeset 0d2ef718ae67 by Éric Araujo in branch '3.1': New changeset c19752ea037f by Éric Araujo in branch 'default': |
Given your approval of the idea and lack of code comments, I committed the patch for 3.3 without requesting more review. |
New changeset 814599728ac0 by Éric Araujo in branch '2.7': |
New changeset f9e2b2b17e58 by Éric Araujo in branch 'default': |
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
bugs.python.org fields:
The text was updated successfully, but these errors were encountered: